Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorials: fix incipit tutorial #645

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

musicEnfanthen
Copy link
Member

@musicEnfanthen musicEnfanthen commented May 20, 2024

This PR adds some improvements for the incipit tutorial, including those proposed in #263 by @mfeustle .

This includes :

  • simplifying the note example in step 4;
  • simplifying and improving readability of the xml:ids used in the final step;
  • improving the explanation of the attributes used in the final step;
  • improving the explanation of the referencing mechanism with xml:ids in the final step;
  • fixing a typo in the title of the incipit tutorial in the Spanish translation.

Fixes #263

@musicEnfanthen
Copy link
Member Author

@martha-thomae May I ask you to have a look at the updated Spanish translations?

@musicEnfanthen musicEnfanthen requested a review from kepper May 21, 2024 07:27
@musicEnfanthen musicEnfanthen changed the title fix(tutorials): fix incipit tutorial tutorials: fix incipit tutorial Jul 21, 2024
@rettinghaus
Copy link
Member

@martha-thomae Could you have a look please?

@musicEnfanthen musicEnfanthen requested review from davidrizo and martha-thomae and removed request for martha-thomae September 27, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Technical issues
Development

Successfully merging this pull request may close these issues.

Tutorials: Suggestions on advanced/incipits tutorial
2 participants